-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Verification #161
Merged
Merged
Improve Verification #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master into trust-individuals
BenWestgate
added
bug
Something isn't working
enhancement
New feature or request
help wanted
Extra attention is needed
labels
May 21, 2024
Closed
New dialogs for Verification depending on whether the pre-Trusted keys passed verification or not. Presents the same check_sigs loop as before if they want extra verification or do not have 3 good sigs. Plan to make it an overall loop checking verify.py each time and passing a higher threshold if the user goes above and beyond the default 3.
We can get rid of most code verifying, downloading and have a much better code footprint outsourcing it to the python script in bitcoin-core.
needed the 3rd field not the 4th since we cd'd into bitcoin-core earlier.
…cation to an --info box.
…o default datadir.
…nt what gpg is doing, move slow gpg --refresh out of first runs, add interpreter for python script, move prune calc to just-in-time.
…ds, add Verify download signatures terminal title, remove reference to .tar.gz file, Extra>More Verication, Download>
…ed for 2 weeks. Don't install-core if b <arg>, just update Bails, environment var for bails VERSION, run bitcoin-qt in background so qt-wrapper can close
@epiccurious: this is fully tested, passing CI and ready for your brief code review. I suggest skimming it so you're familiar with how much the code has changed in this branch so you can find everything later. |
BenWestgate
commented
May 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have read all the changes and they look good to me.
epiccurious
approved these changes
May 26, 2024
ACK ba5c894 |
This was
linked to
issues
May 26, 2024
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
enhancement
New feature or request
help wanted
Extra attention is needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
Closes #128